Feature: rtl support #333
Closed
Feature: rtl support #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Can you please check our changes and pull it into master? Thanks |
wuweiweiwu
commented
Jun 5, 2018
Member
Author
wuweiweiwu
left a comment
wuweiweiwu
left a comment
There was a problem hiding this comment.
Looks Good. Some minor comments and questions
| > | ||
| <div | ||
| className="rst__lineBlock rst__lineHalfHorizontalRight" | ||
| className="rst__lineBlock rst__lineHalfHorizontalRight " |
Member
Author
There was a problem hiding this comment.
Can you get rid of the extra space at the end?
src/tree-node.js
Outdated
| key={`pre_${1 + i}`} | ||
| style={{ width: scaffoldBlockPxWidth }} | ||
| className={`${'rst__lineBlock'} ${lineClass}`} | ||
| className={`${'rst__lineBlock'} ${lineClass} ${directionClass}`} |
Member
Author
There was a problem hiding this comment.
you can use classnames here
| > | ||
| <div | ||
| className="rst__node" | ||
| direction={undefined} |
Member
Author
There was a problem hiding this comment.
why is this undefined in a lot of places?
Member
Author
|
Wow @lionben89 I'm really impressed.
All that is left is adding documentation and a storybook example. If you don't want to add the storybook example I can do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #209
closes: #325
closes: #253
closes: #311
follow up to #331